> On Feb. 5, 2019, 4:57 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 10950 (patched) > > <https://reviews.apache.org/r/69891/diff/1/?file=2123900#file2123900line10950> > > > > I don't know if sending UNREACHABLE for all the 3 cases when > > `_removeSlave` is called is the right way. I think we need to have a > > discussion around the agent state / task state / operation state for each > > of the cases. > > > > What happens if a framework reconciles the operation after this code > > gets executed. Will it always get OPERATION_UNREACHABLE? If not, then that > > would be cnofusing. > > > > Also, the operation status is not changed in-memory here. Is that > > intentional? > > Greg Mann wrote: > Continuing this discussion on Slack: > https://mesos.slack.com/archives/C8NN4M0CT/p1549066656027000 > > Yep, I intended not to update the operation status in this patch. The > JIRA issue is purely for sending updates to frameworks, and I intend to > address all of the operation state updates as part of > https://issues.apache.org/jira/browse/MESOS-9546 since that involves more > significant code changes.
I'm working on an update for this patch which will ensure that we return correct reconciliation results for these operations. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69891/#review212551 ----------------------------------------------------------- On Feb. 5, 2019, 4:24 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69891/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2019, 4:24 p.m.) > > > Review request for mesos, Gastón Kleiman and Joseph Wu. > > > Bugs: MESOS-9541 > https://issues.apache.org/jira/browse/MESOS-9541 > > > Repository: mesos > > > Description > ------- > > This patch makes the master send operation updates when > an agent is removed and a framework has requested > feedback for a pending operation on that agent. > > > Diffs > ----- > > src/master/master.cpp f74b7c280569e1c24e0940463bb28bd795d429d5 > src/tests/master_tests.cpp acc6096239e4992bdca084d88880d644ab4a2385 > > > Diff: https://reviews.apache.org/r/69891/diff/1/ > > > Testing > ------- > > `make check` > `bin/mesos-tests.sh --gtest_filter="*OperationUpdatesAfterAgentShutdown*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
