----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69893/ -----------------------------------------------------------
(Updated Feb. 12, 2019, 5:19 a.m.) Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Changes ------- Addressed Benjamin's comment. Bugs: MESOS-9544 https://issues.apache.org/jira/browse/MESOS-9544 Repository: mesos Description (updated) ------- This patch limits SLRP to only support persistent volumes on MOUNT disks, and makes it clean up data in persistent volumes when processing `DESTROY` operations. NOTE: Persistent volumes backed by CSI disks that are created before upgrading to a Mesos version that does not include this fix are subject to data leakage. To ensure data security, these persistent volume must be consumed by a task at least once after the upgrade before being destroyed. Diffs (updated) ----- src/resource_provider/storage/provider.cpp 09a710d668a5a7460b6c4e4fa32d3829dca7ac55 src/resource_provider/storage/provider_process.hpp 36187fb4a25c49653530ee286fa9c1663177fbc6 Diff: https://reviews.apache.org/r/69893/diff/2/ Changes: https://reviews.apache.org/r/69893/diff/1-2/ Testing ------- `make check` More testing done later in chain. Thanks, Chun-Hung Hsiao