> On Feb. 23, 2019, 11:55 p.m., Vinod Kone wrote: > > support/jenkins/reviewbot.sh > > Lines 38 (patched) > > <https://reviews.apache.org/r/70045/diff/1/?file=2126559#file2126559line38> > > > > I don't think this is needed because verify-reviews.py sets the > > ENVIRONMENT and other variables explicitly before verifying the review. > > > > The comment at #33 should probably moved to #27.
Done. Added a comment on verification setting up its own env to document our assumptions. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70045/#review213122 ----------------------------------------------------------- On Feb. 23, 2019, 9:18 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70045/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2019, 9:18 p.m.) > > > Review request for mesos, Till Toenshoff and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Due to flakes test results reported by reviewbot need manual > verification so we can skip executing tests when validating the > `master` branch. This saves some execution time during validation. > > Incidentally with this patch a previous comment matches now matches > what is happening. > > > Diffs > ----- > > support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73 > > > Diff: https://reviews.apache.org/r/70045/diff/1/ > > > Testing > ------- > > > Thanks, > > Benjamin Bannier > >
