> On March 4, 2019, 10:48 p.m., Greg Mann wrote: > > src/tests/agent_operation_feedback_tests.cpp > > Lines 280-283 (patched) > > <https://reviews.apache.org/r/70117/diff/1/?file=2128639#file2128639line280> > > > > I think we probably only need one test which verifies that this > > particular metric is incremented correctly? I would probably keep the one > > which includes retries.
Hm, my thinking was that it is not only a test for the metrics, but also enhances the existing tests - i.e. if we already would have had them when the test was originally written, we probably would have wanted to include the metrics check there. But I also don't mind taking out some of the test cases again, it certainly makes changes more manageable. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213417 ----------------------------------------------------------- On March 7, 2019, 5:01 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70117/ > ----------------------------------------------------------- > > (Updated March 7, 2019, 5:01 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-8241 > https://issues.apache.org/jira/browse/MESOS-8241 > > > Repository: mesos > > > Description > ------- > > WIP: Add unit tests for offer operation metrics. > > > Diffs > ----- > > src/tests/agent_operation_feedback_tests.cpp > 5a8f54c7c53272e90ed5fa6366e8154cedf1375f > src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2 > src/tests/master_slave_reconciliation_tests.cpp > 002be27bf0731e2dba89376911117b347cd1dd0a > src/tests/master_tests.cpp 5ae8e1cea3ca87551093bd63d744ac807ac7797a > src/tests/operation_reconciliation_tests.cpp > 6a815ad694e2a608ce324715c920833f825793a0 > src/tests/persistent_volume_endpoints_tests.cpp > 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7 > src/tests/reservation_endpoints_tests.cpp > b1897592797c40574de7995b2335f2b4bc5fc699 > src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58 > src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb > src/tests/storage_local_resource_provider_tests.cpp > 75f0d818a94d7a15d1df169683724294e07fdb69 > > > Diff: https://reviews.apache.org/r/70117/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
