----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70150/#review213606 -----------------------------------------------------------
Ship it! Should probably clarify that we're replacing the constructor in the summary? - Benjamin Mahler On March 7, 2019, 7:04 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70150/ > ----------------------------------------------------------- > > (Updated March 7, 2019, 7:04 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > The constructor constructs `ResourceQuantities` > from `google::protobuf::Map<std::string, Value::Scalar>`. > It replaces one of the current constructors that takes > in `OfferFilters::ResourceQuantities`. > > > Diffs > ----- > > src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae > src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 > src/master/allocator/mesos/hierarchical.cpp > 7085c23eeb163854712391e24d902902b8aaf162 > > > Diff: https://reviews.apache.org/r/70150/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
