----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70198/ -----------------------------------------------------------
Review request for mesos and Benjamin Mahler. Repository: mesos Description ------- The method validates the input scalar values to be non-negative normal values ("normal" as defined by `std::fpclassify`). Also refactored some related validation logic and tests. Diffs ----- src/common/validation.hpp d09528f56e8b3675d677159c597399688019e65e src/common/validation.cpp b622a3284cfc528f8245b0300df667d525b7eea3 src/common/values.cpp c788302b928747a1aed66efd4d654711410928f1 src/tests/common_validation_tests.cpp 214b993fa1942f15cfb4c732a5d280274d0512e9 src/tests/master_validation_tests.cpp 9568d39accb00eec68b622fdc7f02249fefbc063 src/v1/values.cpp 5fd9dc5a03ec7b8f6ed31acb3f868764a45b2bfd Diff: https://reviews.apache.org/r/70198/diff/1/ Testing ------- make check Thanks, Meng Zhu