> On March 13, 2019, 12:37 p.m., Benjamin Mahler wrote: > > src/common/resource_quantities.cpp > > Lines 406-418 (patched) > > <https://reviews.apache.org/r/70201/diff/1/?file=2131685#file2131685line406> > > > > This is very clean and readable! I guess we're ok with the re-scanning > > approach instead of walking both alphabetically for now? > > > > (I think it's fine, we can consider optimizing it later if needed)
Yep, agreed. > On March 13, 2019, 12:37 p.m., Benjamin Mahler wrote: > > src/common/resource_quantities.cpp > > Lines 408-409 (patched) > > <https://reviews.apache.org/r/70201/diff/1/?file=2131685#file2131685line408> > > > > How about s/quantityScalar/quantity/ ? > > > > Also fits cleanly on one line that way: > > > > ``` > > >>> len(' foreachpair (const string& name, const Value::Scalar& > > quantity, quantities) {') > > 78 > > ``` Sounds good. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70201/#review213682 ----------------------------------------------------------- On March 12, 2019, 7:13 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70201/ > ----------------------------------------------------------- > > (Updated March 12, 2019, 7:13 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Also added tests. > > > Diffs > ----- > > src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae > src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 > src/tests/resource_quantities_tests.cpp > 435a4949b95e9a83be73781388eb4be9c7da695b > > > Diff: https://reviews.apache.org/r/70201/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
