> On March 13, 2019, 12:29 p.m., Benjamin Mahler wrote: > > src/tests/master_validation_tests.cpp > > Lines 307-308 (original), 164-165 (patched) > > <https://reviews.apache.org/r/70203/diff/1/?file=2131823#file2131823line309> > > > > Do we want the extra spaces after { and before }?
It is consistent with our stout map output. https://github.com/apache/mesos/blob/996862828ca9b7675e40b495fe24d95615bb832b/3rdparty/stout/include/stout/stringify.hpp#L140-L156 - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70203/#review213681 ----------------------------------------------------------- On March 12, 2019, 11:46 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70203/ > ----------------------------------------------------------- > > (Updated March 12, 2019, 11:46 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9596 > https://issues.apache.org/jira/browse/MESOS-9596 > > > Repository: mesos > > > Description > ------- > > Updated a test for `UPDATE_QUOTA` call validation. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > 9568d39accb00eec68b622fdc7f02249fefbc063 > > > Diff: https://reviews.apache.org/r/70203/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
