----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70208/#review213753 -----------------------------------------------------------
Tnis test looks good — however in my experience tests which send only `RESERVE` opertions don't need a resource provider. Removing the instantiation of the RP would make remove a lot of boilerplate and some amount of clock manipulation, thus making the test much shorter, readable and less prone to races. - Gastón Kleiman On March 13, 2019, 6:41 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70208/ > ----------------------------------------------------------- > > (Updated March 13, 2019, 6:41 p.m.) > > > Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang > Yan Xu. > > > Bugs: MESOS-9648 > https://issues.apache.org/jira/browse/MESOS-9648 > > > Repository: mesos > > > Description > ------- > > This patch adds a test to verify that operation reconciliation > via the v1 scheduler API works correctly when multiple > operations in different states are reconciled at the same time. > > > Diffs > ----- > > src/tests/operation_reconciliation_tests.cpp > 6a815ad694e2a608ce324715c920833f825793a0 > > > Diff: https://reviews.apache.org/r/70208/diff/1/ > > > Testing > ------- > > `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
