----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70249/#review213826 -----------------------------------------------------------
Ship it! I agree with the change; `hashmap` extends the interface of `std::unordered_map` and thus should continue to use snake_case for consistency. I don't quite agree with the commit message. While it is correct de jure that we should use snake_case in stout and libprocess, I think de facto >90% of the interactions with these libraries in Mesos code goes through camelCase interfaces (i.e. `Option::isSome()`, `Future::isReady()`) so in general it would be better to update the style guide to reflect this reality. - Benno Evers On March 20, 2019, 9:48 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70249/ > ----------------------------------------------------------- > > (Updated March 20, 2019, 9:48 a.m.) > > > Review request for mesos, Benjamin Hindman and Benno Evers. > > > Repository: mesos > > > Description > ------- > > In stout we use snake case, not camel case. > > We will clean up users outside of stout in a follow-up patch. > > > Diffs > ----- > > 3rdparty/stout/include/stout/hashmap.hpp > 61bf80ea90b97c0aed19f21ac0d258ff370357b6 > 3rdparty/stout/tests/hashmap_tests.cpp > 38a33dc71eb3fce1c7be036c36f4791e86511f1e > > > Diff: https://reviews.apache.org/r/70249/diff/2/ > > > Testing > ------- > > `make check`, not a functional change > > > Thanks, > > Benjamin Bannier > >
