-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/
-----------------------------------------------------------
(Updated March 20, 2019, 9:40 p.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comments and make `UriDiskProfileAdaptor` remain using the
CSI v0 protobuf.
Bugs: MESOS-9625
https://issues.apache.org/jira/browse/MESOS-9625
Repository: mesos
Description (updated)
-------
This patch makes the disk profile adaptor module API and the CSI volume
state protobuf to use the unversioned `VolumeCapability`, so the profile
adaptors and the volume state checkpoints can be upgraded to support CSI
v1 in a backward compatible way.
The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
however, still uses CSI v0 `VolumeCapability` for now, and devolve it
to the unversioned protobuf during profile translation.
Diffs (updated)
-----
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp
739585b84245a85649d36ddde3a6086a5cf309cc
src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
src/csi/v0_volume_manager.hpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
src/csi/volume_manager.hpp PRE-CREATION
src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
src/resource_provider/storage/disk_profile_adaptor.cpp
b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
src/resource_provider/storage/uri_disk_profile_adaptor.hpp
7e610d30110f22cd6ee0745979ef8ced3a07765e
src/resource_provider/storage/uri_disk_profile_adaptor.cpp
cb574be2a4b4e443248b2001f822d739e5bbe7b9
src/tests/disk_profile_adaptor_tests.cpp
0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
Diff: https://reviews.apache.org/r/70248/diff/2/
Changes: https://reviews.apache.org/r/70248/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
