----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70222/#review214050 -----------------------------------------------------------
Ship it! Very nice patch, reviewable even though it is pretty big. Thanks for that! - Benjamin Bannier On March 26, 2019, 6:08 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70222/ > ----------------------------------------------------------- > > (Updated March 26, 2019, 6:08 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9622 > https://issues.apache.org/jira/browse/MESOS-9622 > > > Repository: mesos > > > Description > ------- > > This patch moves volume management code from SLRP to the v0 > `VolumeManager`, and make SLRP uses the `VolumeManager` interface > polymorphically. > > However, since SLRP now no longer keeps track of CSI volume states, it > will not be able to verify that a persistent volume is published before > being destroyed (although this should be guaranteed by volume manager > recovery). > > > Diffs > ----- > > src/csi/v0_volume_manager.cpp PRE-CREATION > src/csi/v0_volume_manager_process.hpp PRE-CREATION > src/resource_provider/storage/provider.cpp > fea623c292158deb1b4b4b9ab1ac208031471519 > src/resource_provider/storage/provider_process.hpp > a5536b3d735e01eb1c4dc52d0602d973155f3c93 > src/tests/storage_local_resource_provider_tests.cpp > 7945384867f26fa15dc734a235ae509d5d6d350f > > > Diff: https://reviews.apache.org/r/70222/diff/4/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
