----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70184/#review214121 -----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp Lines 4926 (patched) <https://reviews.apache.org/r/70184/#comment300291> I'm not sure if this is the most appropriate fix before understanding why the offer was filtered. Can you elaborate more on why this is needed? - Chun-Hung Hsiao On March 11, 2019, 3:39 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70184/ > ----------------------------------------------------------- > > (Updated March 11, 2019, 3:39 p.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9594 > https://issues.apache.org/jira/browse/MESOS-9594 > > > Repository: mesos > > > Description > ------- > > Under some circumstances, offers would be filtered, resulting in the > test being stuck while waiting for offers. This has been resolved by > removing all offer filters before waiting for offers. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 7945384867f26fa15dc734a235ae509d5d6d350f > > > Diff: https://reviews.apache.org/r/70184/diff/1/ > > > Testing > ------- > > make check > > I could not reproduce the flaky behavior of this test case, hence only assume > that this patch resolves the flakiness. > > > Thanks, > > Jan Schlicht > >
