----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70324/#review214131 -----------------------------------------------------------
PASS: Mesos patch 70324 was successfully built and tested. Reviews applied: `['70324']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3029/mesos-review-70324 - Mesos Reviewbot Windows On March 27, 2019, 10 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70324/ > ----------------------------------------------------------- > > (Updated March 27, 2019, 10 a.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, Joseph Wu, and > Meng Zhu. > > > Bugs: MESOS-9635 > https://issues.apache.org/jira/browse/MESOS-9635 > > > Repository: mesos > > > Description > ------- > > This patch deprecates the `addResourceProvider()` allocator method > in favor of a new one, `addAgentResources()`, with exactly the same > logic. The old method is left in place, but its logic is completely > removed. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > f1868387b28ea1d303cd3ed0176e32d66debd4c1 > src/master/allocator/mesos/allocator.hpp > 2d83f382eed9d9dca218adf84bc03883f7486349 > src/master/allocator/mesos/hierarchical.hpp > 36bf90baf413e99c1580d516dfac0f074335d322 > src/master/allocator/mesos/hierarchical.cpp > 8bc749903b8ceb09a02e260919377483479302b5 > src/master/master.cpp acc67d3763ddee9027e6cf375f1d495ff5805026 > src/tests/allocator.hpp 0718bef4de39a82dbcadebb9967d2ff1cceb1cae > src/tests/hierarchical_allocator_tests.cpp > a34fa96fbc455d830c1fd7c1df83f3db72c96ee3 > > > Diff: https://reviews.apache.org/r/70324/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >