----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70168/#review214163 -----------------------------------------------------------
src/csi/service_manager.cpp Lines 263 (patched) <https://reviews.apache.org/r/70168/#comment300350> Called `contains_value` now. - Benjamin Bannier On March 27, 2019, 6:51 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70168/ > ----------------------------------------------------------- > > (Updated March 27, 2019, 6:51 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9632 > https://issues.apache.org/jira/browse/MESOS-9632 > > > Repository: mesos > > > Description > ------- > > Container management is moved out from SLRP to `ServiceManager`. It is > agnostic to CSI versions, so can be used to manage plugin containers for > both CSI v0 and v1 plugins. > > This patch squashes the changes from r/70169. > > > Diffs > ----- > > src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 > src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d > src/csi/service_manager.hpp PRE-CREATION > src/csi/service_manager.cpp PRE-CREATION > src/resource_provider/storage/provider.cpp > 2711503cdb58cb9b34af8c9fad0908c5f788a2af > src/resource_provider/storage/provider_process.hpp > a5536b3d735e01eb1c4dc52d0602d973155f3c93 > > > Diff: https://reviews.apache.org/r/70168/diff/11/ > > > Testing > ------- > > Testing done later in chain. > > > Thanks, > > Chun-Hung Hsiao > >
