-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70344/
-----------------------------------------------------------
(Updated March 29, 2019, 2:28 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Addressed Ben's comment
Summary (updated)
-----------------
Fixed a bug where disk quota may be under allocated.
Bugs: MESOS-9692
https://issues.apache.org/jira/browse/MESOS-9692
Repository: mesos
Description (updated)
-------
The resources chopping logic in the allocator
currently overly shrinks resources with the same
name (e.g. vanilla disk and mount disk) if there
are multiple such resources. Currently only
different disk resources might share the same
name (we only chop unreserved/non-revocable/non-shared
resources). This would lead to disk quota being under
allocated. This patch corrects the shrinking logic.
See MESOS-9692.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp
8bc749903b8ceb09a02e260919377483479302b5
src/tests/hierarchical_allocator_tests.cpp
a34fa96fbc455d830c1fd7c1df83f3db72c96ee3
Diff: https://reviews.apache.org/r/70344/diff/2/
Changes: https://reviews.apache.org/r/70344/diff/1-2/
Testing
-------
make check
Added a dedicated test. The test fails without the fix and passes with the fix.
Thanks,
Meng Zhu
