----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70331/#review214217 -----------------------------------------------------------
Ship it! Looks good to me. Like discussed offline, let's not just run in repetition, but under artifical stress (e.g., via https://kernel.ubuntu.com/~cking/stress-ng/). If we additionally qualify the testing by mentioning the number of repetitions we can also get some understanding of how sure we are to not introduce tests with intermediate flake rates. If we don't observe any flakes in `n` iterations, we have an uncertainty on the success rate `p` of `dp=2/n^2`, e.g., no failures in `n=200` iterations means that we can exclude flake rates of up to 10% with only around 66% uncertainty (roughly since Gaussian propagation of uncertainties assumes normal distributions, not half-normal one like we have here, and isn't derived for points at the edge of restricted intervals). - Benjamin Bannier On March 29, 2019, 10:19 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70331/ > ----------------------------------------------------------- > > (Updated March 29, 2019, 10:19 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9655 > https://issues.apache.org/jira/browse/MESOS-9655 > > > Repository: mesos > > > Description > ------- > > This patch makes the `AgentRegisteredWithNewId` SLRP test to test the > following scenarios: > > * Launch a task to access a volume imported through `CREATE_DISK`. > > * `CREATE_DISK` with a mismatched profile. > > * `DESTROY_DISK` with a `RAW` disk that has been published. > > Since now volumes need to be published, it becomes a ROOT test. > > Together with the `CreateDestroyPreprovisionedVolume` SLRP test, most > scenarios of preprovisioned volumes are now covered. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87 > > > Diff: https://reviews.apache.org/r/70331/diff/2/ > > > Testing > ------- > > sudo make check > > Run in repetition. > > > Thanks, > > Chun-Hung Hsiao > >
