----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/#review214259 -----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70225. Failed command: `python.exe .\support\apply-reviews.py -n -r 70225` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3054/mesos-review-70321 Relevant logs: - [apply-review-70225.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3054/mesos-review-70321/logs/apply-review-70225.log): ``` error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:5195 error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply ``` - Mesos Reviewbot Windows On March 28, 2019, 1:02 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70321/ > ----------------------------------------------------------- > > (Updated March 28, 2019, 1:02 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9624 > https://issues.apache.org/jira/browse/MESOS-9624 > > > Repository: mesos > > > Description > ------- > > Since per-CSI-call metrics are no longer implemented, there is very less > value to keep the `mesos::csi::v0::RPC` enum, which is tightly coupled > with `mesos::csi::v0::Client`. Therefore, the enum and its header are > removed. > > The header and implementation file for `mesos::csi::v0::Client` is also > renamed for future CSI v1 support. > > > Diffs > ----- > > src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 > src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d > src/csi/client.hpp c2583cf4c0d2abc38d65ddc801cae3696a8080a9 > src/csi/client.cpp 9e17f5bcb902470045dac704f2471d2962336e48 > src/csi/rpc.hpp b2502ceb319638038b4d151965f6226db675f96b > src/csi/rpc.cpp e8a2770a6d8ae48a717ed93fa872e9edee45e618 > src/csi/service_manager.cpp PRE-CREATION > src/csi/v0_client.hpp PRE-CREATION > src/csi/v0_volume_manager.cpp PRE-CREATION > src/csi/v0_volume_manager_process.hpp PRE-CREATION > src/tests/csi_client_tests.cpp c8f3f04e6bff40d62dd0f85fcc146d71fa9e5d34 > src/tests/storage_local_resource_provider_tests.cpp > 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87 > > > Diff: https://reviews.apache.org/r/70321/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
