> On April 4, 2019, 9:43 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1708 (original), 1712-1722 (patched) > > <https://reviews.apache.org/r/70393/diff/1/?file=2137466#file2137466line1712> > > > > I am confused > > > > Couldn't we just do > > > > ``` > > foreachkey (const string& role, quotaGuarantees) { > > rolesConsumedQuota[role] += > > > > reservationScalarQuantities.get(role).getOrElse(ResourceQuantities()); > > } > > > > ``` > > > > After your previous patch where you made `reservationScalarQuantities` > > hierarchical?
I'll tweak the existing test to catch this bug - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70393/#review214375 ----------------------------------------------------------- On April 4, 2019, 7 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70393/ > ----------------------------------------------------------- > > (Updated April 4, 2019, 7 p.m.) > > > Review request for mesos and Meng Zhu. > > > Bugs: MESOS-9688 and MESOS-9691 > https://issues.apache.org/jira/browse/MESOS-9688 > https://issues.apache.org/jira/browse/MESOS-9691 > > > Repository: mesos > > > Description > ------- > > There was an invalid assumption that the sorter returns > hierarchically aggregated allocation information, whereas > it actually returns the "." internal node information. This > patch adjusts the allocator code accordingly. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 1fd8b021c9954c37533dc193b3148def5ff53071 > > > Diff: https://reviews.apache.org/r/70393/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
