----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70390/#review214395 -----------------------------------------------------------
Patch looks great! Reviews applied: [70391, 70392, 70393, 70370, 70373, 70374, 70382, 70390] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 4, 2019, 8:31 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70390/ > ----------------------------------------------------------- > > (Updated April 4, 2019, 8:31 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This test verifies that the headroom accounting is correct in the > presence of subrole allocation. In particular, we need to ensure > that a subrole's allocation is accounted only once (not multiple > times in itself as well as all of its ancestors) when calculating > available the quota headroom. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > c7edee2f49bfac0796c9506265d3bb766416ee63 > > > Diff: https://reviews.apache.org/r/70390/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
