----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70396/#review214429 -----------------------------------------------------------
Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp Lines 6192-6193 (patched) <https://reviews.apache.org/r/70396/#comment300627> Maybe say we add the framework first to be clear that it's active when agent 2 shows up? src/tests/hierarchical_allocator_tests.cpp Lines 6194-6195 (patched) <https://reviews.apache.org/r/70396/#comment300629> This seems counter-intuitive, but then I noticed it's explained at the bottom of the test, seems to be better explained up here? src/tests/hierarchical_allocator_tests.cpp Lines 6241-6245 (patched) <https://reviews.apache.org/r/70396/#comment300628> Weird but yeah, ditto the other comment (probably it makes more sense for the reader to pull this up right beneath or integrated into the explananation of the test setup?) Can we also put a TODO that indicates how this test will need to change once we have hierarchical quota? - Benjamin Mahler On April 5, 2019, 12:37 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70396/ > ----------------------------------------------------------- > > (Updated April 5, 2019, 12:37 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This test ensures that a nested role's allocation is accounted > to the top-level role's consumed quota. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > c7edee2f49bfac0796c9506265d3bb766416ee63 > > > Diff: https://reviews.apache.org/r/70396/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
