----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214523 -----------------------------------------------------------
Patch looks great! Reviews applied: [70411, 70412] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 10, 2019, 7:56 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70412/ > ----------------------------------------------------------- > > (Updated April 10, 2019, 7:56 a.m.) > > > Review request for mesos, Benno Evers and Greg Mann. > > > Repository: mesos > > > Description > ------- > > This patch adds a flag to the operation feedback example framework that > makes it unreserve resources that were reserved by another instance of > the framework. > > NOTE: The new flag should only be enabled if the example framework is > the only framework making reservations for a given role. Otherwise it > will unreserve reservations made by another framework. > > > Diffs > ----- > > src/examples/operation_feedback_framework.cpp > 2480c340c4ccb4246098c35e0315093f3eb44e81 > > > Diff: https://reviews.apache.org/r/70412/diff/3/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Gastón Kleiman > >