----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214543 -----------------------------------------------------------
Patch looks great! Reviews applied: [70408, 70377, 70379] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 10, 2019, 3:35 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70379/ > ----------------------------------------------------------- > > (Updated April 10, 2019, 3:35 p.m.) > > > Review request for mesos and Gastón Kleiman. > > > Bugs: MESOS-2842 > https://issues.apache.org/jira/browse/MESOS-2842 > > > Repository: mesos > > > Description > ------- > > Added validation that the principal stays the same on resubscription. > > > Diffs > ----- > > src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 > > > Diff: https://reviews.apache.org/r/70379/diff/3/ > > > Testing > ------- > > make check > > Now the two failing tests from https://reviews.apache.org/r/70377/ pass. > > > Thanks, > > Andrei Sekretenko > >