----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70466/#review214631 -----------------------------------------------------------
Ship it! Ship It! - Benno Evers On April 12, 2019, 11:40 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70466/ > ----------------------------------------------------------- > > (Updated April 12, 2019, 11:40 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benno Evers. > > > Repository: mesos > > > Description > ------- > > Since glog-0.4.0 the glog cmake build seems to find a system-wide > installation of gflags and use that to implicitly enable additional > features which we do not use. Due to the way glog is integrated into > our cmake build we can then end up in a situation where we > successfully build the bundled glog, but cannot include all its > required headers. > > This patch fixes the cmake flags of the bundled glog so it never uses > gflags which 1) is more deterministic and 2) addresses above mentioned > build issue. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 0a33ed9e3258da299318c151f268f6fa18064dde > > > Diff: https://reviews.apache.org/r/70466/diff/1/ > > > Testing > ------- > > `ninja tests` > > > Thanks, > > Benjamin Bannier > >
