----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70472/#review214779 -----------------------------------------------------------
src/master/validation.cpp Lines 21 (patched) <https://reviews.apache.org/r/70472/#comment301039> Do we still need this include? Or was it already needed from existing code and this patch slips it in? src/master/validation.cpp Line 1347 (original), 1366 (patched) <https://reviews.apache.org/r/70472/#comment301041> Don't we need to touch this too? - Benjamin Mahler On April 20, 2019, 7:14 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70472/ > ----------------------------------------------------------- > > (Updated April 20, 2019, 7:14 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Gastón Kleiman, and > Meng Zhu. > > > Bugs: MESOS-9619 > https://issues.apache.org/jira/browse/MESOS-9619 > > > Repository: mesos > > > Description > ------- > > This patch adds validation to the master to ensure that task > groups do not include resources with overlapping set- or > range-valued resources, as this can crash the allocator. > > > Diffs > ----- > > src/master/validation.hpp 71748c121aa3518d68811ea1e60707d195b58657 > src/master/validation.cpp f032a781608857d0c9cfa220dd8d70f74d60f1ec > > > Diff: https://reviews.apache.org/r/70472/diff/4/ > > > Testing > ------- > > Testing details at the end of this chain. > > > Thanks, > > Greg Mann > >
