----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70594/#review215059 -----------------------------------------------------------
Ship it! Slick solution, thanks, Ben! - Alexander Rukletsov On May 3, 2019, 7:58 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70594/ > ----------------------------------------------------------- > > (Updated May 3, 2019, 7:58 p.m.) > > > Review request for mesos, Alexander Rukletsov and Chun-Hung Hsiao. > > > Bugs: MESOS-9766 > https://issues.apache.org/jira/browse/MESOS-9766 > > > Repository: mesos > > > Description > ------- > > It's possible for /__processes__ to never return a response if > a process is terminated after the /__processes__ handler dispatches > to it, thus leading the Future to be abandoned. > > This patch ensures we ignore those cases, rather than wait forever. > > See MESOS-9766. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 124836472313721a5dbfe4b1ca55f0da3cecd66b > > > Diff: https://reviews.apache.org/r/70594/diff/1/ > > > Testing > ------- > > Added a test in the subsequent patch. > > > Thanks, > > Benjamin Mahler > >