----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70656/#review215302 -----------------------------------------------------------
Patch looks great! Reviews applied: [70656] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 16, 2019, 12:56 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70656/ > ----------------------------------------------------------- > > (Updated May 16, 2019, 12:56 p.m.) > > > Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Joseph Wu. > > > Bugs: MESOS-9786 > https://issues.apache.org/jira/browse/MESOS-9786 > > > Repository: mesos > > > Description > ------- > > Also added a test. > > > Diffs > ----- > > src/master/quota_handler.cpp 5d449e6f027a69ccaa0ac3473ea4cf57441601f3 > src/tests/master_quota_tests.cpp 66641f2d4e1dc7fd3d1da8d83dc4a45b447fc4bf > > > Diff: https://reviews.apache.org/r/70656/diff/1/ > > > Testing > ------- > > make check > Also added a dedicated test. > > The test would crash the master without the fix. After applying the fix, the > test runs continously without failure. > > > Thanks, > > Meng Zhu > >