----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70637/#review215318 -----------------------------------------------------------
Patch looks great! Reviews applied: [70661, 70637] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 16, 2019, 11:47 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70637/ > ----------------------------------------------------------- > > (Updated May 16, 2019, 11:47 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > The hierarchical allocator a number of has CHECKs that enforce > the invariants about the state of roles, agents and frameworks. > This change adds the relevant IDs to the CHECK message so that > it is easier to track down the root cause of failures. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 875cfcd091f5f58afb89e752da5100a75828dd67 > > > Diff: https://reviews.apache.org/r/70637/diff/2/ > > > Testing > ------- > > make check (Fedora 30) > > > Thanks, > > James Peach > >
