----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70651/#review215319 -----------------------------------------------------------
Fix it, then Ship it! src/tests/api_tests.cpp Lines 2618 (patched) <https://reviews.apache.org/r/70651/#comment301985> s/notified/broadcast to subscribers/ src/tests/api_tests.cpp Lines 2774 (patched) <https://reviews.apache.org/r/70651/#comment301986> Nit: make this a const ref? src/tests/api_tests.cpp Lines 2781 (patched) <https://reviews.apache.org/r/70651/#comment301987> Nit: const ref? src/tests/api_tests.cpp Line 2782 (original), 2792 (patched) <https://reviews.apache.org/r/70651/#comment301988> Nit: const ref? - Greg Mann On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70651/ > ----------------------------------------------------------- > > (Updated May 16, 2019, 5:11 a.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-9785 > https://issues.apache.org/jira/browse/MESOS-9785 > > > Repository: mesos > > > Description > ------- > > If one subscribes to master's `/api/v1` endpoint after a master failover > but before an agent reregistration, frameworks recovered through the > agent registration should be notified to the subscriber, otherwise > recovered tasks will have framework IDs referring to frameworks unknown > to the subscriber. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def > src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 > src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d > > > Diff: https://reviews.apache.org/r/70651/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
