----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70661/#review215320 -----------------------------------------------------------
Ship it! - Benjamin Mahler On May 17, 2019, 6:46 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70661/ > ----------------------------------------------------------- > > (Updated May 17, 2019, 6:46 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > Added a simple `CHECK_CONTAINS` and `CHECK_NOT_CONTAINS` to replace > checks of the form `CHECK(foo.contains(bar))`. These macros format > the value of the key in their failure message to assist debugging. > > > Diffs > ----- > > 3rdparty/stout/include/stout/check.hpp > 7651150bb6cbe148af1e148658deff3d65ae4746 > > > Diff: https://reviews.apache.org/r/70661/diff/1/ > > > Testing > ------- > > make check (Fedora 30) > > > Thanks, > > James Peach > >
