----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70683/#review215403 -----------------------------------------------------------
Fix it, then Ship it! src/internal/evolve.hpp Lines 106-114 (original), 122-133 (patched) <https://reviews.apache.org/r/70683/#comment302088> This helper doesn't seem to fit well, and we'd only use this helper in a single spot later on in the chain. I'd suggest to remove it here and just manually adjust in the later patch. - Benjamin Bannier On May 21, 2019, 12:30 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70683/ > ----------------------------------------------------------- > > (Updated May 21, 2019, 12:30 a.m.) > > > Review request for mesos, Benjamin Bannier and Greg Mann. > > > Bugs: MESOS-9485 > https://issues.apache.org/jira/browse/MESOS-9485 > > > Repository: mesos > > > Description > ------- > > Added helpers for evolving operation-related proto messages. > > > Diffs > ----- > > src/internal/evolve.hpp 1044d9df75b6fc1f60d3704be9cb5751e6d4321d > src/internal/evolve.cpp 19c155967bf090fb2ec39211805ff1385787ab59 > > > Diff: https://reviews.apache.org/r/70683/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
