----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70669/ -----------------------------------------------------------
(Updated May 21, 2019, 1:49 p.m.) Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258 https://issues.apache.org/jira/browse/MESOS-7258 Repository: mesos Description ------- This patch adds `user` and `checkpoint` fields of `FrameworkInfo` into the `validateUpdate()` function for the purpose of using this function to implement the UPDATE_FRAMEWORK call. To preserve the legacy behaviour of re-subscription which silently ignores these fields, the re-subscription path now explicitly sets them to their old values. Diffs (updated) ----- src/master/master.cpp 24bd9572741c033c02d03a3a3a35d7d4ed8b60de src/master/validation.hpp 97c24064b127b1625a58fbc8ac189f18599b0495 src/master/validation.cpp 39f5bfdb39fd6944a3e893b1587e3c2e26818d27 src/tests/master_validation_tests.cpp f102906a4d4fd54328e91fef33eb1b34aa6ce646 Diff: https://reviews.apache.org/r/70669/diff/2/ Changes: https://reviews.apache.org/r/70669/diff/1-2/ Testing ------- Thanks, Andrei Sekretenko