----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70628/#review215425 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Bannier On May 11, 2019, 1:07 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70628/ > ----------------------------------------------------------- > > (Updated May 11, 2019, 1:07 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and James DeFelice. > > > Bugs: MESOS-9779 > https://issues.apache.org/jira/browse/MESOS-9779 > > > Repository: mesos > > > Description > ------- > > Since 404 is returned if the API endpoint route is not set yet, this > error code becomes ambiguous and makes clients hard to programmatically > handle it. Therefore, the error code for specifying a missing config > in this API call is changed to 409 Conflict. > > > Diffs > ----- > > include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0 > include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d > src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d > src/tests/agent_resource_provider_config_api_tests.cpp > 7185ac00b5137c7ab208b623e36d03ffd43aab6e > > > Diff: https://reviews.apache.org/r/70628/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
