----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215617 -----------------------------------------------------------
Fix it, then Ship it! This looks pretty sweet, thanks for going the extra mile and improving our unit test suite! src/tests/master/mock_master_api_subscriber.cpp Lines 80 (patched) <https://reviews.apache.org/r/70671/#comment302370> Nit: No `.` at the end of log messages. (same for the messages below) - Benno Evers On May 29, 2019, 7:17 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70671/ > ----------------------------------------------------------- > > (Updated May 29, 2019, 7:17 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > ------- > > This patch introduces a class with mock methods for subscribing to the > events of master's V1 streaming API and setting expectations for them. > > > Diffs > ----- > > src/Makefile.am 5f97523fbe2d80733fbdcc7706f2761f5a071f9f > src/tests/CMakeLists.txt e6b1d8a097246f0921467d7f778034d6754fcff6 > src/tests/master/mock_master_api_subscriber.hpp PRE-CREATION > src/tests/master/mock_master_api_subscriber.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70671/diff/4/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
