> On May 31, 2019, 3:05 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > > Lines 287-290 (patched) > > <https://reviews.apache.org/r/70748/diff/1/?file=2147040#file2147040line287> > > > > Can we also test that a client must *not* present a cert? I believe the > > answer is _no_, but a TODO or a NOTE could be helpful.
I guess we could let `curl` make a request against a server with `verify_cert=true`, but that seems unrelated to the change in this review, so it should probably become a separate review later in the chain. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/#review215616 ----------------------------------------------------------- On June 6, 2019, 11:12 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70748/ > ----------------------------------------------------------- > > (Updated June 6, 2019, 11:12 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jan-Philip Gehrcke, Joseph Wu, > and Till Toenshoff. > > > Bugs: MESOS-9810 > https://issues.apache.org/jira/browse/MESOS-9810 > > > Repository: mesos > > > Description > ------- > > When in SSL client mode and `LIBPROCESS_SSL_VERIFY_CERT=true` has > been set, enforce that the server actually presents a certificate > that can be verified. > > Note that in most cases, the TLS stack would rejected the connection > before the code ever reaches `openssl::verify()`, since the TLS > specification that a server MUST always send a certificate unless > an anonymous cipher is used. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.hpp > 17bec246e516261f8d772f1647c17f092fae82d1 > 3rdparty/libprocess/src/openssl.cpp > e7dbd67913fa8e7fbbf60dee428e7e38895f86ce > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > 29a1bf71c1df9d80370455a6269ecea0ec4193b0 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 6b8496aeeed79ae1bd39d7013f4f403b248fdd4c > > > Diff: https://reviews.apache.org/r/70748/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
