----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70756/#review215761 -----------------------------------------------------------
Patch looks great! Reviews applied: [70532, 70663, 70664, 70665, 70668, 70669, 70670, 70533, 70778, 70671, 70756] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 29, 2019, 6:42 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70756/ > ----------------------------------------------------------- > > (Updated May 29, 2019, 6:42 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > This patch replaces reading out all Master API events (both interesting > and uninteresting ones) in the code of the tests with setting > expectations on `MOCK_METHOD`s of the dedicated class. > > > Diffs > ----- > > src/tests/api_tests.cpp 2220cecc22778a86f0c29317adf495927e1a900d > > > Diff: https://reviews.apache.org/r/70756/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >