----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215774 -----------------------------------------------------------
Fix it, then Ship it! Nice tests, thank you Andrei! src/tests/master/update_framework_tests.cpp Lines 150 (patched) <https://reviews.apache.org/r/70534/#comment302617> s/update/newInfo/ src/tests/master/update_framework_tests.cpp Lines 150 (patched) <https://reviews.apache.org/r/70534/#comment302618> how about: s/update/newInfo/ src/tests/master/update_framework_tests.cpp Lines 157-158 (patched) <https://reviews.apache.org/r/70534/#comment302614> This seems a little brittle, as we probably should be failing FrameworkInfo validation when there is an UNKNOWN capability. Seems like a bug that it's not getting checked How about REGION_AWARE? src/tests/master/update_framework_tests.cpp Lines 164-169 (patched) <https://reviews.apache.org/r/70534/#comment302615> Remove "without_resources"? I'm not sure what it's trying to communicate, but it seems to carry too much context from somewhere else, is it named this way because of a test? src/tests/master/update_framework_tests.cpp Lines 170 (patched) <https://reviews.apache.org/r/70534/#comment302619> newline src/tests/master/update_framework_tests.cpp Lines 174 (patched) <https://reviews.apache.org/r/70534/#comment302620> s/std::string/string/ here and below src/tests/master/update_framework_tests.cpp Lines 274 (patched) <https://reviews.apache.org/r/70534/#comment302621> As an aside, the error above says "Updating" and this one says "Changing", should probably make the language consistent src/tests/master/update_framework_tests.cpp Lines 370-375 (patched) <https://reviews.apache.org/r/70534/#comment302622> This looks racy..? The agent may get added before the subscriber subscribes, in which case the AGENT_ADDED event wouldn't be sent because the agent gets included in the initial SUBSCRIBE state. src/tests/master/update_framework_tests.cpp Lines 493 (patched) <https://reviews.apache.org/r/70534/#comment302624> Why resume and re-pause the clock? src/tests/master/update_framework_tests.cpp Lines 512 (patched) <https://reviews.apache.org/r/70534/#comment302625> Why resume? src/tests/master/update_framework_tests.cpp Lines 562-565 (patched) <https://reviews.apache.org/r/70534/#comment302631> ``` Future<Event::Rescind> rescind; EXPECT_CALL(*scheduler, rescind(_, _)) .WillOnce(FutureArg<1>(&rescind)); ``` src/tests/master/update_framework_tests.cpp Lines 569-570 (patched) <https://reviews.apache.org/r/70534/#comment302629> ``` // TODO(asekretenko): Add a more in-depth check that the // allocator does what it should. ``` - Benjamin Mahler On June 3, 2019, 8:14 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70534/ > ----------------------------------------------------------- > > (Updated June 3, 2019, 8:14 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > ------- > > Added tests for the V1 UPDATE_FRAMEWORK call. > > > Diffs > ----- > > src/Makefile.am 5f97523fbe2d80733fbdcc7706f2761f5a071f9f > src/tests/CMakeLists.txt e6b1d8a097246f0921467d7f778034d6754fcff6 > src/tests/master/update_framework_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70534/diff/9/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
