----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70855/#review215917 -----------------------------------------------------------
Ship it! src/tests/master/update_framework_tests.cpp Line 609 (original), 610 (patched) <https://reviews.apache.org/r/70855/#comment302866> newline src/tests/master/update_framework_tests.cpp Lines 611 (patched) <https://reviews.apache.org/r/70855/#comment302867> DriverErrorWhenCalledBeforeRegistration src/tests/master/update_framework_tests.cpp Lines 648 (patched) <https://reviews.apache.org/r/70855/#comment302865> stray newline? src/tests/master/update_framework_tests.cpp Lines 649 (patched) <https://reviews.apache.org/r/70855/#comment302862> Probably just `frameworkId` here and elsewhere (can't seem to see any other values to warrant the "registered" name) src/tests/master/update_framework_tests.cpp Line 812 (original), 886 (patched) <https://reviews.apache.org/r/70855/#comment302863> I guess `s/_/&driver/` like the other ones above? - Benjamin Mahler On June 14, 2019, 12:51 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70855/ > ----------------------------------------------------------- > > (Updated June 14, 2019, 12:51 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This patch makes the exitsing UpdateFramewornV0 tests fill the > `FrameworkInfo.id` field and adds tests that invalid values of this > field are handled properly. > > > Diffs > ----- > > src/tests/master/update_framework_tests.cpp > 1b0fb8d108dbf174af381bdc5536181b25b9f7a9 > > > Diff: https://reviews.apache.org/r/70855/diff/3/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkV0*ID*" > --gtest_break_on_failure --gtest_repeat=1000` > > > Thanks, > > Andrei Sekretenko > >
