----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70863/#review215932 -----------------------------------------------------------
Ship it! Ship It! - Qian Zhang On June 17, 2019, 10:47 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70863/ > ----------------------------------------------------------- > > (Updated June 17, 2019, 10:47 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-9805 > https://issues.apache.org/jira/browse/MESOS-9805 > > > Repository: mesos > > > Description > ------- > > Currently, the PID targeted by the cgroups isolator is moved into > the cgroup before the subsystem runs to apply any type-specific > cgroup configuration. We should reverse the order of this so that > the PID is only moved once the cgroup is fully configured by the > subsystem. > > A specific case that can happen is where a PID is assigned to a net_cls > cgroup before that cgroup has its class ID set. This intermediate > process state can be observed by system monitoring process, causing > confusion that is hard to debug. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 4a1871b3b06b54a02dfe09289f7fb304a3f7f24c > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > e7819d732172bdbd215106e3b781588c1f78b2ec > > > Diff: https://reviews.apache.org/r/70863/diff/1/ > > > Testing > ------- > > sudo make check (Fedora 30) > > > Thanks, > > James Peach > >
