----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70906/#review216002 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer.cpp Lines 166-176 (patched) <https://reviews.apache.org/r/70906/#comment302938> Not indented far enough. src/tests/containerizer.cpp Line 166 (original), 176-179 (patched) <https://reviews.apache.org/r/70906/#comment302939> Extra newline - Greg Mann On June 20, 2019, 1:30 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70906/ > ----------------------------------------------------------- > > (Updated June 20, 2019, 1:30 p.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > In order for a `MockExecutor` to be able to reregister after agent > restart a persisted pid is required. This patch adds checkpointing of > the pid. > > > Diffs > ----- > > src/tests/containerizer.cpp fab7e81339f3b7b3fec2a4f6cb7e3a52df2607ed > > > Diff: https://reviews.apache.org/r/70906/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
