> On June 20, 2019, 6:36 p.m., Meng Zhu wrote: > > src/common/http.hpp > > Lines 219-221 (patched) > > <https://reviews.apache.org/r/70877/diff/1/?file=2150637#file2150637line220> > > > > Why the namespace here and below?
It's needed to compile, clang can't seem to match the aapropriate overload otherwise > On June 20, 2019, 6:36 p.m., Meng Zhu wrote: > > src/master/readonly_handler.cpp > > Line 744 (original), 701 (patched) > > <https://reviews.apache.org/r/70877/diff/1/?file=2150639#file2150639line744> > > > > what is this for? notice that `master` is used in the lambdas (this is the same style as the other jsonify handlers) > On June 20, 2019, 6:36 p.m., Meng Zhu wrote: > > src/master/readonly_handler.cpp > > Lines 766-770 (original), 721-736 (patched) > > <https://reviews.apache.org/r/70877/diff/1/?file=2150639#file2150639line768> > > > > Not very important, but I find putting shorter/simpler case on the top > > would improve readibilty. Sounds good - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70877/#review216007 ----------------------------------------------------------- On June 18, 2019, 7:13 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70877/ > ----------------------------------------------------------- > > (Updated June 18, 2019, 7:13 p.m.) > > > Review request for mesos and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > Updated master's /roles endpoint to use jsonify. > > > Diffs > ----- > > src/common/http.hpp a0f9b67dca86f7c035035abed5d497aaf759bb10 > src/common/http.cpp dcf3cb0234fc81e155dae2267764c1dd7bed5201 > src/master/readonly_handler.cpp 66d6160c5e951e6c3a51eb02c31ead066c322202 > > > Diff: https://reviews.apache.org/r/70877/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
