----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70885/#review216015 -----------------------------------------------------------
Ship it! Thanks a bunch - much better signal for a pricy function now :) - Till Toenshoff On June 19, 2019, 2:44 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70885/ > ----------------------------------------------------------- > > (Updated June 19, 2019, 2:44 p.m.) > > > Review request for mesos, Joseph Wu and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Renamed member function `hostname()` to `lookup_hostname()`, > since the former name hides the fact that a call to this > function involves a synchronous network access in order > to make a reverse DNS lookup. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > e740e840c38381bafd7a1a7fcde5f963832ac1fb > 3rdparty/libprocess/src/tests/http_tests.cpp > 97aaf3ed3d4fab6d717d5c9b6d12402562ac6b46 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 6b8496aeeed79ae1bd39d7013f4f403b248fdd4c > > > Diff: https://reviews.apache.org/r/70885/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
