----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70886/#review216060 -----------------------------------------------------------
Patch looks great! Reviews applied: [70747, 70748, 70810, 70883, 70884, 70885, 70796, 70749, 70795, 70921, 70797, 70886] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 19, 2019, 2:48 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70886/ > ----------------------------------------------------------- > > (Updated June 19, 2019, 2:48 p.m.) > > > Review request for mesos, Jan-Philip Gehrcke, Joseph Wu, and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Ignore an executor's reported IP address and enforce the hostname > "localhost" instead for TLS hostname validation. > > NOTE: This change is for illustration purposes only, and is not > intended to be upstreamed. > > > Diffs > ----- > > src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e > > > Diff: https://reviews.apache.org/r/70886/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >