----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70925/#review216064 -----------------------------------------------------------
Ship it! Thanks! Usually we would put this test after the fix, because if it gets committed first it will break the build. - Benjamin Mahler On June 21, 2019, 5:38 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70925/ > ----------------------------------------------------------- > > (Updated June 21, 2019, 5:38 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9856 > https://issues.apache.org/jira/browse/MESOS-9856 > > > Repository: mesos > > > Description > ------- > > This patch exposes a bug, due to which reviveOffers() called for > a specific role clears offer filters for all the roles of a framework. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 7dc3dc1392b120e2798dcd68f7290cae4afa890d > > > Diff: https://reviews.apache.org/r/70925/diff/1/ > > > Testing > ------- > > make check - this test fails > > > Thanks, > > Andrei Sekretenko > >
