----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70923/#review216102 -----------------------------------------------------------
src/master/registry_operations.cpp Lines 422-433 (patched) <https://reviews.apache.org/r/70923/#comment303094> I do not see the capability removed anywhere. But in the previous patch, we said: ``` To remove this minimum capability requirement: ``` I am OK with not removing any minimum capability (even they are not needed anymore). But we should mention that in the doc. - Meng Zhu On June 21, 2019, 9 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70923/ > ----------------------------------------------------------- > > (Updated June 21, 2019, 9 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-9814 > https://issues.apache.org/jira/browse/MESOS-9814 > > > Repository: mesos > > > Description > ------- > > This adds the associated registry operation and fields for the > DRAIN_AGENT master call. This call affects admitted or unreachable > agents and thus has data fields into two parts of the registry. > > When agents transition from reachable to unreachable, or vice > versa, the draining info is now copied too. > > Because this feature is not downgrade compatible, a minimum capability > is added when the draining feature is used. > > > Diffs > ----- > > src/master/registry.proto 239789322c45c6a8346332f50661a98b1851b685 > src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b > src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4 > src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8 > > > Diff: https://reviews.apache.org/r/70923/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
