----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70916/#review216117 -----------------------------------------------------------
Fix it, then Ship it! src/master/quota_handler.cpp Lines 375-379 (patched) <https://reviews.apache.org/r/70916/#comment303112> Is something going to change here that we should document? Some more context would be helpful src/master/quota_handler.cpp Line 736 (original), 753-755 (patched) <https://reviews.apache.org/r/70916/#comment303120> A bit more context in the comment for the reader would be helpful, e.g. is this going to stay as is because a new action type is in place for the new api? src/master/quota_handler.cpp Lines 758 (patched) <https://reviews.apache.org/r/70916/#comment303111> const auto& - Benjamin Mahler On June 24, 2019, 10:22 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70916/ > ----------------------------------------------------------- > > (Updated June 24, 2019, 10:22 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9807 > https://issues.apache.org/jira/browse/MESOS-9807 > > > Repository: mesos > > > Description > ------- > > This paves way to remove `struct Quota`. > > > Diffs > ----- > > src/master/master.hpp 7acaa8264eb7a37e17394bc4940971f872ab2de3 > src/master/master.cpp d15b2d9dbc79e95c15b689f29f88cebb76f94dd8 > src/master/quota_handler.cpp 854189cd052cc88b4dc0ade72c63ac9a1b0bcbb5 > src/master/readonly_handler.cpp d62f139ed25dc6d03e91f76bf6574ad8c3c6baa0 > > > Diff: https://reviews.apache.org/r/70916/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
