----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70797/#review216379 -----------------------------------------------------------
Ship it! Ship It! - Till Toenshoff On July 2, 2019, 5:53 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70797/ > ----------------------------------------------------------- > > (Updated July 2, 2019, 5:53 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This commit adds some unit tests to verify the newly added > `hostname_validation_scheme` flag is working as intended. > > While going through the existing tests to look for candidates > that would benefit from being tested for both hostname validation > schemes, I noticed a number of existing tests where test setup > did not quite match the comment or test name. I fixed these up > in this review as well. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 6cdd7815f4389cd398defe56260a73eb710a4d8f > 3rdparty/libprocess/src/tests/ssl_client.cpp > de87b3b89c84d17f2ebba1f09e9ec682f139aace > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 5d360221937e68da185754f0633fa41a217c7107 > > > Diff: https://reviews.apache.org/r/70797/diff/5/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
