----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71032/#review216424 -----------------------------------------------------------
Patch looks great! Reviews applied: [71031, 71027, 71028, 71029, 71030, 71032] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 8, 2019, 6:07 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71032/ > ----------------------------------------------------------- > > (Updated July 8, 2019, 6:07 p.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-9871 > https://issues.apache.org/jira/browse/MESOS-9871 > > > Repository: mesos > > > Description > ------- > > This ensures that the various edge different states of resources > are correctly handled, see test comment for more details. > > > Diffs > ----- > > src/tests/role_tests.cpp bf5b3cba59d38eee41ed222d14bc8c928fcf2a79 > > > Diff: https://reviews.apache.org/r/71032/diff/1/ > > > Testing > ------- > > Ran 1000 times in repetition. > > > Thanks, > > Benjamin Mahler > >