----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71030/#review216467 -----------------------------------------------------------
Patch looks great! Reviews applied: [71027, 71028, 71029, 71030] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 10, 2019, 1:19 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71030/ > ----------------------------------------------------------- > > (Updated July 10, 2019, 1:19 a.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-9871 > https://issues.apache.org/jira/browse/MESOS-9871 > > > Repository: mesos > > > Description > ------- > > Per the previous commit that adds the consumed quota computation, > consumed quota is: > > Allocation + Unallocated Reservation == > Reservations + Unreserved Allocation > > That is, reservations count towards quota regardless of whether > they're allocated. Allocation counts towards quota. Offered resources > *do not* count towards quota, this is to (1) provide stability of the > quota consumption metrics in the face of offers flowing in and out, > and (2) to ensure that we treat offers as rescindable and therefore > not yet "counting" towards quota. Also, if in the future schedulers > are offered more than their quota to improve their choices, counting > offered resources as consumed quota will be problematic. > > > Diffs > ----- > > src/master/readonly_handler.cpp 0d1e3dc19352863263c3e8992a63852c7f27225b > src/tests/role_tests.cpp bf5b3cba59d38eee41ed222d14bc8c928fcf2a79 > > > Diff: https://reviews.apache.org/r/71030/diff/2/ > > > Testing > ------- > > Added a test in a subsequent patch. > > > Thanks, > > Benjamin Mahler > >
