----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71043/#review216488 -----------------------------------------------------------
Ship it! Nice! src/webui/app/roles/roles.html Line 17 (original), 17 (patched) <https://reviews.apache.org/r/71043/#comment303720> I feel we should remove offered here, just show allocation? Given current UI, there is no way to tell amount of allocation. I doubt if users care much about offered. - Meng Zhu On July 9, 2019, 8:31 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71043/ > ----------------------------------------------------------- > > (Updated July 9, 2019, 8:31 p.m.) > > > Review request for mesos and Meng Zhu. > > > Bugs: MESOS-9618 > https://issues.apache.org/jira/browse/MESOS-9618 > > > Repository: mesos > > > Description > ------- > > This keeps the existing 'Allocation + Offered' column, rather than > removing it. However, it would be nice to add additional columns > for reservation, offered resources, and allocation quantities. Then > we can remove the old 'Allocation + Offered' column, but will > probably want to introduce the ability for the user to enable / > disable columns while viewing. > > > Diffs > ----- > > src/webui/app/roles/roles.html 02cb7ba09845d4f9b51630d9c59c1bbd533ac478 > > > Diff: https://reviews.apache.org/r/71043/diff/2/ > > > Testing > ------- > > Ran locally. > > > File Attachments > ---------------- > > post-change > > https://reviews.apache.org/media/uploaded/files/2019/07/10/da7ac898-35a8-45ff-a434-d98bd76c0e79__Screen_Shot_2019-07-09_at_10.43.20_PM.png > tooltip > > https://reviews.apache.org/media/uploaded/files/2019/07/10/db7677dd-6647-4d44-9c20-b35ca5b7de85__Screen_Shot_2019-07-09_at_11.28.42_PM.png > > > Thanks, > > Benjamin Mahler > >
